The Artima Developer Community
Sponsored Link

Artima Developer Spotlight Forum
Who's the Worst Programmer on Your Team, and How Can You Tell?

47 replies on 4 pages. Most recent reply: Dec 22, 2008 10:05 AM by James Watson

Welcome Guest
  Sign In

Go back to the topic listing  Back to Topic List Click to reply to this topic  Reply to this Topic Click to search messages in this forum  Search Forum Click for a threaded view of the topic  Threaded View   
Previous Topic   Next Topic
Flat View: This topic has 47 replies on 4 pages [ « | 1 2 3 4 ]
James Watson

Posts: 2024
Nickname: watson
Registered: Sep, 2005

Re: Who's the Worst Programmer on Your Team, and How Can You Tell? Posted: Dec 19, 2008 6:08 PM
Reply to this message Reply
Advertisement
> It's funny that programmer posts of this thread nature are
> always about the other guy that sucks.

Not really. This you are talking about the equivalent self-selected survey. Few people think they suck even if they do. And if you truly suck and know it, you are unlikely to read programming articles and much less so to post responses about how you suck. Although, I do have a pet theory that people who post suggesting that it's silly or wrong to judge other programmers may themselves suck at programming and know at least that other programmers think they suck. I've noticed that in code reviews, the people who dislike them the most are the ones who receive the most negative feedback. I suppose that's unsurprising. If you aren't good at your job, the last thing you want is someone critiquing your work.

Dick Ford

Posts: 149
Nickname: roybatty
Registered: Sep, 2003

Re: Who's the Worst Programmer on Your Team, and How Can You Tell? Posted: Dec 20, 2008 10:28 AM
Reply to this message Reply
> > It's funny that programmer posts of this thread nature
> are
> > always about the other guy that sucks.
>
> Not really. This you are talking about the equivalent
> self-selected survey. Few people think they suck even if
> they do. And if you truly suck and know it, you are
> unlikely to read programming articles and much less so to
> post responses about how you suck. Although, I do have a
> pet theory that people who post suggesting that it's silly
> or wrong to judge other programmers may themselves suck at
> programming and know at least that other programmers think
> they suck. I've noticed that in code reviews, the people
> who dislike them the most are the ones who receive the
> most negative feedback. I suppose that's unsurprising.
> If you aren't good at your job, the last thing you want
> t is someone critiquing your work.

I think I just posted that I suck....sometimes at least ;) What I've noticed about other people's code is that it's not consistently bad or consistently good. Sometimes their code sucks and sometimes it's good.

Code critiquing is subjective though. There's no getting around that. It's the nature of writing code that there's an infinite number of good ways to write a non-trivial piece of code and an infinite number of ways to write bad code.

Sure, most programmers can tell if a chunk truly sucks really bad, but once you get into that middle ground you get into much more subjectiveness.

There's just too many variables, including different programming languages and the idiomatic ways to program in that language.

James Watson

Posts: 2024
Nickname: watson
Registered: Sep, 2005

Re: Who's the Worst Programmer on Your Team, and How Can You Tell? Posted: Dec 22, 2008 10:05 AM
Reply to this message Reply
> Code critiquing is subjective though. There's no getting
> around that. It's the nature of writing code that there's
> an infinite number of good ways to write a non-trivial
> piece of code and an infinite number of ways to write bad
> code.

There are things about judging code that are subjective but there are also a lot of important things that can be judged objectively. When I review code, I try to make a distinction between what must be fixed and what I suggest as improvements.

A list of some things about code that can be judged objectively:

* Are all error paths accounted for and dealt with in a reasonable manner such that (at the very least) issues can be determined from logs?
* Does the code follow formatting and naming standards?
* Does the code contain highly inefficient approaches when better approaches can be easily substituted?
* Does the code do what it's supposed to do?
* Does the source contain extraneous code i.e. code that does nothing.

That's a good portion of what I look for in a code review. It's pretty rare that the code I am given meets all of these requirements. The other main things that I look for are awkward approaches and unnecessary complexity which are definitely subjective.

Flat View: This topic has 47 replies on 4 pages [ « | 1  2  3  4 ]
Topic: The New Old Previous Topic   Next Topic Topic: Native Apps in the Browser

Sponsored Links



Google
  Web Artima.com   

Copyright © 1996-2019 Artima, Inc. All Rights Reserved. - Privacy Policy - Terms of Use